Commit graph

4 commits

Author SHA1 Message Date
0ko
24b54a36e4 fix(dropdown): a11y: add tooltip to opener in Actions, + ui: fix rounding, + improve demos (#13052)
## Accessibility fix

Followup to forgejo/forgejo!10133. E2E test added.

Add "Tore actions" tooltip (and consequentially `aria-label`) to this opener so it has meaning to screen readers.

|![](https://codeberg.org/attachments/d07d3012-6967-4134-8bf4-216e4f5acc02)|
|-|

Unfortunately, the Tr key "profile.actions.tooltip" is badly named but it's already used in many places and will just be renamed to something generic at some point.

## Improved demo page

|![](https://codeberg.org/attachments/2a31f18e-1141-49df-8717-8d8b981586cf)|
|-|

## Fixed rounding correctness

I've crammed it here to avoid merge conflicts while waiting for review

|Before|After|
|-|-|
|![](https://codeberg.org/attachments/53347567-d890-4c87-ac48-ed64651e2dba)|![](https://codeberg.org/attachments/d40321c9-2e00-45f1-a8ea-261f607cdf6c)|

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13052
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2026-07-17 21:04:58 +02:00
Cameron Radmore
1a277ad0b8 chore: have stylelint lint CSS in tmpl files to enforce RTL-friendly logical properties (#13216)
This will allow us to enforce RTL-friendly logical CSS properties in the go template files.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13216
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2026-07-04 17:05:27 +02:00
Nirmal Kumar R
49f9cc7c4d chore: dialog modal max-width rendering failure (#12469)
The dialog element shrink wrap up to the max-width boundary. The
`long-modal` is set to strictly fit the `800px` width in the test.
However with Playwright minor font rendering differences makes the
dialog modal width resulting in `797px`.

Test fails at: [expect(width).toBe(800);](6132d0e406/tests/e2e/modal.test.e2e.ts (L103))

The fix is to increase the content of the `#long-model` element in
`templates/demo/model.tmpl` to 300 characters length instead of the
current `100` characters length ensures that the dialog modal will always
hit the `800px` max-width.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12469
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
2026-05-08 08:01:34 +02:00
0ko
3cafb7fa6c chore(ui): change /devtest to /-/demo (#11019)
It has always been largely used for showcasing UI elements but that name didn't work too well for it.

Testing:
Some of existing tests depend on these pages, making it redundant to create extra tests.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11019
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2026-01-26 13:12:25 +01:00