mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-12 20:48:40 +00:00
85d38e354d
A runner can either belong to an owner (user, organization) or a repository, not both. While `CreateRunner()` enforces that, `UpdateRunner()` does not, which leads to bugs. With this change, `UpdateRunner()` rejects runners that have _both_ fields set to prevent unexpected ownership changes. Resolves https://codeberg.org/forgejo/forgejo/issues/12106 and makes https://codeberg.org/forgejo/forgejo/pulls/12117 obsolete. ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13262 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| TestActionTask_GetAvailableJobsForRunner | ||
| TestActionTask_GetTasksByRunnerRequestKey | ||
| TestRunner_FindRunnerOptionsToConds | ||
| TestRunner_GetVisibleRunnerByID | ||
| artifact.go | ||
| forgejo.go | ||
| forgejo_test.go | ||
| main_test.go | ||
| pre_execution_errors.go | ||
| pre_execution_errors_test.go | ||
| pre_execution_warnings.go | ||
| pre_execution_warnings_test.go | ||
| run.go | ||
| run_job.go | ||
| run_job_list.go | ||
| run_job_list_test.go | ||
| run_job_status_test.go | ||
| run_job_test.go | ||
| run_list.go | ||
| run_list_test.go | ||
| run_priority.go | ||
| run_priority_test.go | ||
| run_test.go | ||
| runner.go | ||
| runner_list.go | ||
| runner_test.go | ||
| runner_token.go | ||
| runner_token_test.go | ||
| schedule.go | ||
| schedule_spec.go | ||
| schedule_spec_list.go | ||
| schedule_spec_test.go | ||
| schedule_test.go | ||
| status.go | ||
| task.go | ||
| task_list.go | ||
| task_output.go | ||
| task_step.go | ||
| task_test.go | ||
| tasks_version.go | ||
| user.go | ||
| user_test.go | ||
| utils.go | ||
| utils_test.go | ||
| variable.go | ||