mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-12 20:48:40 +00:00
fixes #12108 docs PR: https://codeberg.org/forgejo/docs/pulls/1893 ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [x] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. *The decision if the pull request will be shown in the release notes is up to the mergers / release team.* The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead. ## Testing Related PRs: - https://code.forgejo.org/forgejo/end-to-end/pulls/2063 - https://code.forgejo.org/forgejo/oci-mirror/pulls/69 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12200 Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org> Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
158 lines
4.2 KiB
Go
158 lines
4.2 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package swift
|
|
|
|
import (
|
|
"archive/zip"
|
|
"bytes"
|
|
"strings"
|
|
"testing"
|
|
|
|
"forgejo.org/modules/util"
|
|
|
|
"github.com/hashicorp/go-version"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
const (
|
|
packageDescription = "Package Description"
|
|
packageRepositoryURL = "https://gitea.io/gitea/gitea"
|
|
packageAuthor = "KN4CK3R"
|
|
packageEmail = "example@example.com"
|
|
packageLicense = "https://opensource.org/license/mit"
|
|
)
|
|
|
|
func TestParsePackage(t *testing.T) {
|
|
createArchive := func(files map[string][]byte) *bytes.Reader {
|
|
var buf bytes.Buffer
|
|
zw := zip.NewWriter(&buf)
|
|
for filename, content := range files {
|
|
w, _ := zw.Create(filename)
|
|
w.Write(content)
|
|
}
|
|
zw.Close()
|
|
return bytes.NewReader(buf.Bytes())
|
|
}
|
|
|
|
t.Run("MissingManifestFile", func(t *testing.T) {
|
|
data := createArchive(map[string][]byte{"dummy.txt": {}})
|
|
|
|
p, err := ParsePackage(data, data.Size(), nil)
|
|
assert.Nil(t, p)
|
|
require.ErrorIs(t, err, ErrMissingManifestFile)
|
|
})
|
|
|
|
t.Run("ManifestFileTooLarge", func(t *testing.T) {
|
|
data := createArchive(map[string][]byte{
|
|
"Package.swift": make([]byte, maxManifestFileSize+1),
|
|
})
|
|
|
|
p, err := ParsePackage(data, data.Size(), nil)
|
|
assert.Nil(t, p)
|
|
require.ErrorIs(t, err, ErrManifestFileTooLarge)
|
|
})
|
|
|
|
t.Run("WithoutMetadata", func(t *testing.T) {
|
|
content1 := "// swift-tools-version:5.7\n//\n// Package.swift"
|
|
content2 := "// swift-tools-version:5.6\n//\n// Package@swift-5.6.swift"
|
|
|
|
data := createArchive(map[string][]byte{
|
|
"Package.swift": []byte(content1),
|
|
"Package@swift-5.5.swift": []byte(content2),
|
|
})
|
|
|
|
p, err := ParsePackage(data, data.Size(), nil)
|
|
assert.NotNil(t, p)
|
|
require.NoError(t, err)
|
|
|
|
assert.NotNil(t, p.Metadata)
|
|
assert.Empty(t, p.Metadata.RepositoryURLs)
|
|
assert.Len(t, p.Manifests, 2)
|
|
m := p.Manifests[""]
|
|
assert.Equal(t, "5.7", m.ToolsVersion)
|
|
assert.Equal(t, content1, m.Content)
|
|
m = p.Manifests["5.5"]
|
|
assert.Equal(t, "5.6", m.ToolsVersion)
|
|
assert.Equal(t, content2, m.Content)
|
|
})
|
|
|
|
t.Run("WithMetadata", func(t *testing.T) {
|
|
data := createArchive(map[string][]byte{
|
|
"Package.swift": []byte("// swift-tools-version:5.7\n//\n// Package.swift"),
|
|
})
|
|
|
|
p, err := ParsePackage(
|
|
data,
|
|
data.Size(),
|
|
strings.NewReader(`{"description":"`+packageDescription+`","licenseURL":"`+packageLicense+`","author":{"name":"`+packageAuthor+`"},"repositoryURLs":["`+packageRepositoryURL+`"]}`),
|
|
)
|
|
assert.NotNil(t, p)
|
|
require.NoError(t, err)
|
|
|
|
assert.NotNil(t, p.Metadata)
|
|
assert.Len(t, p.Manifests, 1)
|
|
m := p.Manifests[""]
|
|
assert.Equal(t, "5.7", m.ToolsVersion)
|
|
|
|
assert.Equal(t, packageDescription, p.Metadata.Description)
|
|
assert.Equal(t, packageLicense, p.Metadata.LicenseURL)
|
|
assert.Equal(t, packageAuthor, p.Metadata.Author.Name)
|
|
assert.ElementsMatch(t, []string{packageRepositoryURL}, p.Metadata.RepositoryURLs)
|
|
})
|
|
|
|
t.Run("WithInvalidMetadata", func(t *testing.T) {
|
|
data := createArchive(map[string][]byte{
|
|
"Package.swift": []byte("// swift-tools-version:5.7\n//\n// Package.swift"),
|
|
})
|
|
|
|
p, err := ParsePackage(
|
|
data,
|
|
data.Size(),
|
|
strings.NewReader(`{"description":"`+packageDescription+`","licenseURL":"`+packageLicense+`","author":{"email":"`+packageEmail+`"},"repositoryURLs":["`+packageRepositoryURL+`"]}`),
|
|
)
|
|
assert.Nil(t, p)
|
|
require.ErrorIs(t, err, util.ErrInvalidArgument)
|
|
})
|
|
}
|
|
|
|
func TestTrimmedVersionString(t *testing.T) {
|
|
cases := []struct {
|
|
Version *version.Version
|
|
Expected string
|
|
}{
|
|
{
|
|
Version: version.Must(version.NewVersion("1")),
|
|
Expected: "1.0",
|
|
},
|
|
{
|
|
Version: version.Must(version.NewVersion("1.0")),
|
|
Expected: "1.0",
|
|
},
|
|
{
|
|
Version: version.Must(version.NewVersion("1.0.0")),
|
|
Expected: "1.0",
|
|
},
|
|
{
|
|
Version: version.Must(version.NewVersion("1.0.1")),
|
|
Expected: "1.0.1",
|
|
},
|
|
{
|
|
Version: version.Must(version.NewVersion("1.0+meta")),
|
|
Expected: "1.0",
|
|
},
|
|
{
|
|
Version: version.Must(version.NewVersion("1.0.0+meta")),
|
|
Expected: "1.0",
|
|
},
|
|
{
|
|
Version: version.Must(version.NewVersion("1.0.1+meta")),
|
|
Expected: "1.0.1",
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
assert.Equal(t, c.Expected, TrimmedVersionString(c.Version))
|
|
}
|
|
}
|