TheAfriForge/gitforge
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2026-07-12 20:48:40 +00:00
Code Issues Projects Releases Packages Wiki Activity
gitforge/modules/templates
History
Exact
0ko b4c8a8dbb2 fix(ui): bring back non-empty check to ThemeName (#13175) 
Followup to https://codeberg.org/forgejo/forgejo/pulls/13110, which introduced a regression.

`SignedUser` is not guaranteed to be nil for guest users. Instead, we're setting it to non-nil user with ID 0 in some places, like:
e7c45cd9c8/services/context/org.go (L168-L171)

In https://codeberg.org/forgejo/forgejo/pulls/13110, I removed the check assuming it was for handling cases where real user's theme is set to "", after making sure it can't happen. This broke display of org pages to guest users and no tests caught it.

This unreliability of `SignedUser` doesn't seem ideal but I've assessed my chances of improving this without introducing more regressions as low, so I just brought the check back.

Noticed on v16.next. Demonstration:
![](https://codeberg.org/attachments/14ece26b-f02a-4e73-90a3-057d1a9962af)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13175
Reviewed-by: Robert Wolff <mahlzahn@posteo.de>
2026-06-23 11:53:17 +02:00
..
eval chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
scopedtmpl chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
vars Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
base.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
context.go chore: move template context (#8663) 2025-07-25 11:55:15 +02:00
context_test.go chore: move template context (#8663) 2025-07-25 11:55:15 +02:00
dynamic.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
helper.go fix(ui): bring back non-empty check to ThemeName (#13175) 2026-06-23 11:53:17 +02:00
helper_test.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
htmlrenderer.go chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
htmlrenderer_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
mailer.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
main_test.go chore: move all test blank imports in a single package (#10662) 2026-01-02 05:32:32 +01:00
static.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
templates_bindata.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
util_avatar.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
util_date.go feat(ui): commit view redesign for pull request page (#7948) 2026-06-02 20:12:32 +02:00
util_date_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
util_dict.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
util_json.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
util_misc.go fix: store pull mirror creds encrypted with keying (#11909) 2026-04-04 13:53:22 +02:00
util_misc_test.go chore: Fix outdated usage of unittest.OverrideFixtures (#7772) 2025-05-03 15:24:56 +00:00
util_render.go chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
util_render_test.go feat(ui): commit view redesign for pull request page (#7948) 2026-06-02 20:12:32 +02:00
util_slice.go Improve template helper functions: string/slice (#24266) 2023-04-22 14:16:22 -04:00
util_string.go feat(issue-search): support query syntax (#9109) 2025-11-19 16:05:42 +01:00
util_string_test.go templates: HasPrefix support for template.HTML 2024-02-16 15:20:52 +01:00
util_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00