mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-14 05:28:39 +00:00
8734e71a26
Regression in #12776 -- `[service].REQUIRE_SIGNIN_VIEW` and `[service.explore].REQUIRE_SIGNIN_VIEW` values were being cached into a constructed middleware during module initialization, before the `settings` object had been initialized by reading settings from the config. As a result, neither setting applied to the middleware. Apparently zero automated tests cover this capability. Fixed by changing the bool into a closure for realtime access to the setting. Added automated tests. Verified that the tests failed when broken. ### Tests for Go changes - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. - Prerelease regression. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13304 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org>
66 lines
2.2 KiB
Go
66 lines
2.2 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/test"
|
|
"forgejo.org/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestExploreUser(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// Set the default sort order
|
|
defer test.MockVariableValue(&setting.UI.ExploreDefaultSort, "reversealphabetically")()
|
|
|
|
cases := []struct{ sortOrder, expected string }{
|
|
{"", "?sort=" + setting.UI.ExploreDefaultSort + "&q="},
|
|
{"newest", "?sort=newest&q="},
|
|
{"oldest", "?sort=oldest&q="},
|
|
{"alphabetically", "?sort=alphabetically&q="},
|
|
{"reversealphabetically", "?sort=reversealphabetically&q="},
|
|
}
|
|
for _, c := range cases {
|
|
req := NewRequest(t, "GET", "/explore/users?sort="+c.sortOrder)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
h := NewHTMLParser(t, resp.Body)
|
|
href, _ := h.Find(`.list-header details.dropdown > .content > ul > li > a.active[href^="?sort="]`).Attr("href")
|
|
assert.Equal(t, c.expected, href)
|
|
}
|
|
|
|
// these sort orders shouldn't be supported, to avoid leaking user activity
|
|
cases404 := []string{
|
|
"/explore/users?sort=lastlogin",
|
|
"/explore/users?sort=reverselastlogin",
|
|
"/explore/users?sort=leastupdate",
|
|
"/explore/users?sort=reverseleastupdate",
|
|
}
|
|
for _, c := range cases404 {
|
|
req := NewRequest(t, "GET", c).SetHeader("Accept", "text/html")
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
}
|
|
|
|
t.Run("REQUIRE_SIGNIN_VIEW", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
defer test.MockVariableValue(&setting.Service.RequireSignInView, true)()
|
|
req := NewRequest(t, "GET", "/explore/users")
|
|
resp := MakeRequest(t, req, http.StatusSeeOther)
|
|
assert.Equal(t, "/user/login", resp.Header().Get("Location"))
|
|
})
|
|
|
|
t.Run("[explore].REQUIRE_SIGNIN_VIEW", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
defer test.MockVariableValue(&setting.Service.Explore.RequireSigninView, true)()
|
|
req := NewRequest(t, "GET", "/explore/users")
|
|
resp := MakeRequest(t, req, http.StatusSeeOther)
|
|
assert.Equal(t, "/user/login", resp.Header().Get("Location"))
|
|
})
|
|
}
|