mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-25 02:48:05 +00:00
A runner can either belong to an owner (user, organization) or a repository, not both. While `CreateRunner()` enforces that, `UpdateRunner()` does not, which leads to bugs. With this change, `UpdateRunner()` rejects runners that have _both_ fields set to prevent unexpected ownership changes. Resolves https://codeberg.org/forgejo/forgejo/issues/12106 and makes https://codeberg.org/forgejo/forgejo/pulls/12117 obsolete. ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13262 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
85 lines
1.8 KiB
Go
85 lines
1.8 KiB
Go
// Copyright 2026 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package private
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"forgejo.org/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestParseScope(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
scope string
|
|
expectedOwner int64
|
|
expectedRepo int64
|
|
expectedError string
|
|
}{
|
|
{
|
|
name: "instance scope",
|
|
scope: "",
|
|
expectedOwner: 0,
|
|
expectedRepo: 0,
|
|
},
|
|
{
|
|
name: "user scope",
|
|
scope: "user2",
|
|
expectedOwner: 2,
|
|
expectedRepo: 0,
|
|
},
|
|
{
|
|
name: "organization scope",
|
|
scope: "org3",
|
|
expectedOwner: 3,
|
|
expectedRepo: 0,
|
|
},
|
|
{
|
|
name: "unknown user",
|
|
scope: "does-not-exist",
|
|
expectedError: "user does not exist",
|
|
},
|
|
{
|
|
name: "repository scope",
|
|
scope: "user2/test_workflows",
|
|
expectedOwner: 0,
|
|
expectedRepo: 62,
|
|
},
|
|
{
|
|
name: "empty repository",
|
|
scope: "user2/",
|
|
expectedError: "repository does not exist",
|
|
},
|
|
{
|
|
name: "unknown repository",
|
|
scope: "user2/does-not-exist",
|
|
expectedError: "repository does not exist",
|
|
},
|
|
{
|
|
name: "owner mismatch",
|
|
scope: "org3/test_workflows",
|
|
expectedError: "repository does not exist",
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
owner, repo, err := ParseScope(t.Context(), testCase.scope)
|
|
|
|
if testCase.expectedError == "" {
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, testCase.expectedOwner, owner)
|
|
assert.Equal(t, testCase.expectedRepo, repo)
|
|
} else {
|
|
require.ErrorContains(t, err, testCase.expectedError)
|
|
}
|
|
})
|
|
}
|
|
}
|