mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-25 19:07:59 +00:00
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/13143 The details of the refactor are in [a separate branch](https://codeberg.org/limiting-factor/forgejo/commits/branch/wip-api-context-accessors-save) which details how it was done. This pull request contains a squash of those commits rebased on top of the current Forgejo branch, which involved conflict resolution. Given the magnitude of the change, there is a high chance that a large number of future pull requests merged in Forgejo will create conflicts. They will be dealt with in the same way as chore: refactor orgAssignment to two separate middlewares (#13155). ## Review The only risk I can think of is a getter/setter implementation being incorrectly implemented. This is probably where a detailed review is most needed, in the `services/context/api.go` file. To not increase the size of the pull request, the `GetX()` accessors were preserved although they are redundant with `X()`. They will be removed in a followup pull request. ## Backporting strategy. Cherry-picking the commit to v15 has a significant amount of conflicts in 8 files out of 111. ``` unmerged routers/api/v1/activitypub/repository.go unmerged routers/api/v1/admin/user.go unmerged routers/api/v1/api.go unmerged routers/api/v1/org/team.go unmerged routers/api/v1/repo/action.go unmerged routers/api/v1/repo/pull.go unmerged routers/api/v1/user/follower.go unmerged services/context/api.go ``` Instead of resolving them, I think it is easier and safer to repeat the [refactor steps](https://codeberg.org/limiting-factor/forgejo/commits/branch/wip-api-context-accessors-save) in v15. I also think it is worth the effort since it will avoid trivial backport conflicts on over 100 files. ## Context This is a followup pull request discussed originally at https://codeberg.org/forgejo/forgejo/pulls/12512 Co-authored-by: limiting-factor <limiting-factor@posteo.com> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13213 Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org> Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
86 lines
2.4 KiB
Go
86 lines
2.4 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package context
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
|
|
user_model "forgejo.org/models/user"
|
|
redirect_service "forgejo.org/services/redirect"
|
|
)
|
|
|
|
// UserAssignmentWeb returns a middleware to handle context-user assignment for web routes
|
|
func UserAssignmentWeb() func(ctx *Context) {
|
|
return func(ctx *Context) {
|
|
errorFn := func(status int, title string, obj any) {
|
|
err, ok := obj.(error)
|
|
if !ok {
|
|
err = fmt.Errorf("%s", obj)
|
|
}
|
|
if status == http.StatusNotFound {
|
|
ctx.NotFound(title, err)
|
|
} else {
|
|
ctx.ServerError(title, err)
|
|
}
|
|
}
|
|
ctx.ContextUser = userAssignment(ctx.Base, ctx.Doer, errorFn)
|
|
ctx.Data["ContextUser"] = ctx.ContextUser
|
|
}
|
|
}
|
|
|
|
// UserIDAssignmentAPI returns a middleware to handle context-user assignment for api routes
|
|
func UserIDAssignmentAPI() func(ctx *APIContext) {
|
|
return func(ctx *APIContext) {
|
|
userID := ctx.ParamsInt64(":user-id")
|
|
|
|
if ctx.IsSigned() && ctx.Doer().ID == userID {
|
|
ctx.SetUser(ctx.Doer())
|
|
} else {
|
|
var err error
|
|
user, err := user_model.GetUserByID(ctx, userID)
|
|
if err != nil {
|
|
if user_model.IsErrUserNotExist(err) {
|
|
ctx.Error(http.StatusNotFound, "GetUserByID", err)
|
|
} else {
|
|
ctx.Error(http.StatusInternalServerError, "GetUserByID", err)
|
|
}
|
|
}
|
|
ctx.SetUser(user)
|
|
}
|
|
}
|
|
}
|
|
|
|
// UserAssignmentAPI returns a middleware to handle context-user assignment for api routes
|
|
func UserAssignmentAPI() func(ctx *APIContext) {
|
|
return func(ctx *APIContext) {
|
|
ctx.SetUser(userAssignment(ctx.Base, ctx.Doer(), ctx.Error))
|
|
}
|
|
}
|
|
|
|
func userAssignment(ctx *Base, doer *user_model.User, errCb func(int, string, any)) (contextUser *user_model.User) {
|
|
username := ctx.Params(":username")
|
|
|
|
if doer != nil && doer.LowerName == strings.ToLower(username) {
|
|
contextUser = doer
|
|
} else {
|
|
var err error
|
|
contextUser, err = user_model.GetUserByName(ctx, username)
|
|
if err != nil {
|
|
if user_model.IsErrUserNotExist(err) {
|
|
if redirectUserID, err := redirect_service.LookupUserRedirect(ctx, doer, username); err == nil {
|
|
RedirectToUser(ctx, username, redirectUserID)
|
|
} else if user_model.IsErrUserRedirectNotExist(err) {
|
|
errCb(http.StatusNotFound, "GetUserByName", err)
|
|
} else {
|
|
errCb(http.StatusInternalServerError, "LookupRedirect", err)
|
|
}
|
|
} else {
|
|
errCb(http.StatusInternalServerError, "GetUserByName", err)
|
|
}
|
|
}
|
|
}
|
|
return contextUser
|
|
}
|