mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-18 23:47:50 +00:00
c90d5b0336
Some files excluded from the nilnil lint and listed in https://codeberg.org/forgejo/forgejo/issues/11261 contain no violations of the lint anymore. I removed them from the list. They are - `routers/api/packages/container/auth.go` - `routers/api/packages/nuget/auth.go` - `routers/web/repo/setting/runners.go` - `services/issue/commit.go` - `services/migrations/onedev.go` Other files contained lints that are triggered by returning `nil` for maps. This can be mitigated easily by returning `make(map[...]...)`. All except one of those return statements are already covered by tests. I list the ones that have coverage now, the statement that has no coverage was not changed. ### Tests for Go changes - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13230 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| fixtures/TestIsPrivate | ||
| action.go | ||
| action_list.go | ||
| action_test.go | ||
| error.go | ||
| federated_user_activity.go | ||
| federated_user_activity_test.go | ||
| main_test.go | ||
| notification.go | ||
| notification_list.go | ||
| notification_test.go | ||
| repo_activity.go | ||
| repo_activity_test.go | ||
| statistic.go | ||
| user_heatmap.go | ||
| user_heatmap_test.go | ||