mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-19 07:58:38 +00:00
6132d0e406
Some notes: - I didn't write integration tests because it's a pure bugfix that addresses implementation details of the model layer. - I can see interpretations of "it involves interactions with a live Forgejo server" that would cover this PR, but they don't make sense to me in context. - I didn't add anything to the documentation because it's a pure bugfix - the system should always have worked this way - there's no value in confusing people trying to figure out how the system works now with how it didn't work in the past - However, there IS value in informing people who may have gotten bitten by this in the past, so I think a release note makes sense - These fixes are closely related, and the changes small, so I decided to make just one PR. - From a user perspective, this is just one issue, and I think in terms of release notes, it makes more sense to have just this one. - Technically, fixing only one of the underlying issues would be enough. Since this is a case of invalid states being representable, it makes sense to both try to prevent it happening in the first place, and deal with it gracefully if it does happen. - At the very least, fixing #12245 is required unless we want to live with data generated in the past being broken Fixes #12243 Fixes #12245 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12302 Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| actions | ||
| activities | ||
| admin | ||
| asymkey | ||
| auth | ||
| avatars | ||
| db | ||
| dbfs | ||
| fixtures | ||
| forgefed | ||
| forgejo/semver | ||
| forgejo_migrations | ||
| forgejo_migrations_legacy | ||
| git | ||
| gitea_migrations | ||
| issues | ||
| moderation | ||
| organization | ||
| packages | ||
| perm | ||
| project | ||
| pull | ||
| quota | ||
| repo | ||
| secret | ||
| shared/types | ||
| system | ||
| unit | ||
| unittest | ||
| user | ||
| webhook | ||
| error.go | ||
| main_test.go | ||
| org.go | ||
| org_team.go | ||
| org_team_test.go | ||
| org_test.go | ||
| repo.go | ||
| repo_test.go | ||
| repo_transfer.go | ||
| repo_transfer_test.go | ||