Mathieu Fenniak 958cface13 fix: terminate git (& other) subcommands gracefully on context timeout/cancellation (#13263) ... By default, when you create an `exec.CommandContext` in Go, when the context is cancelled or timed out, Go will SIGKILL the subprocess which does not allow the subprocess to perform any cleanup work. As some git operations in Forgejo will be linked to the current HTTP context, and the current HTTP context will be closed when the HTTP client disconnects, this can theoretically cause SIGKILLs when locks are being held. This PR contains two fixes: - Change the behaviour of all subprocesses that Forgejo creates to use a graceful termination, SIGTERM'ing the process, and then SIGKILL'ing it after a timeout. - Fixes a bug where previously all subprocesses are setup in a process group (by 1d04e8641d), but they were never *killed* in a process group, preventing child processes from receiving these termination signals. Both SIGTERM and SIGKILL are sent to the process group. Introduces new configuration setting which controls subcommand graceful timeouts. If a subprocess does not shutdown from SIGTERM within `[server].SUBPROCESS_TERMINATE_GRACE` (default 5 seconds), then an error will be logged, and the process will be SIGKILL'd. The error is: ``` 2026/07/01 08:31:20 modules/log/init.go:38:func2() [E] Subprocess pid=3790963 (/nix/store/c0277k5giric1mn9dklllavbzvxl6hzb-git-2.53.0/bin/git blame --porcelain 8ee7e7c32b -- options/locale/locale_en-US.ini) failed to terminate from SIGTERM after grace period 0s, and was sent SIGKILL. The subprocess termination may leave incomplete state on the server, such as lock files. `[server].SUBPROCESS_TERMINATE_GRACE` can be changed to give subprocesses more time to cleanly exit. ``` (This was produced on a live server by setting SUBPROCESS_TERMINATE_GRACE to zero seconds, loading a page that does a `git blame`, and hitting escape in the browser quickly.) ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - Will create a documentation PR with new config settings. - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13263 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>		2026-07-01 20:26:02 +02:00
..
config
actions.go	chore: unify signing key configuration across modules (#11194)	2026-04-21 19:39:33 +02:00
actions_test.go	chore: unify signing key configuration across modules (#11194)	2026-04-21 19:39:33 +02:00
admin.go
admin_test.go
api.go
asset_dynamic.go
asset_static.go
attachment.go
attachment_test.go
authorized_integration.go	feat: cache OIDC metadata & JWKS when read by authorized integration (#12275)	2026-04-28 02:13:06 +02:00
badges.go
cache.go
camo.go
config.go	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
config_env.go	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
config_env_test.go
config_provider.go
config_provider_test.go
cors.go
cron.go
cron_test.go
database.go	chore: upgrade to https://code.forgejo.org/xorm/xorm v1.4.0 (#12639)	2026-05-20 20:20:08 +02:00
database_sqlite.go
database_test.go
disposable_email_domain_data.go
f3.go
f3_test.go
federation.go
forgejo_storage_test.go
git.go	feat: fsck incoming objects (#12695)	2026-05-25 14:51:04 +02:00
git_test.go	feat: fsck incoming objects (#12695)	2026-05-25 14:51:04 +02:00
highlight.go
i18n.go
incoming_email.go
incoming_email_test.go
indexer.go	Add code search with zoekt support (#8827)	2026-05-28 20:52:34 +02:00
indexer_test.go
lfs.go	chore: remove #11024 workarounds (#12301)	2026-05-01 22:10:10 +02:00
lfs_test.go
log.go	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
log_test.go
mailer.go
mailer_test.go
markup.go	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
metrics.go
migrations.go
mime_type_map.go
mirror.go	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
moderation.go
oauth2.go	feat: add option to use preferred_username claim when registering users via oauth2 (#12504)	2026-05-18 00:14:46 +02:00
oauth2_test.go
other.go
packages.go
packages_test.go
path.go
path_test.go
picture.go
project.go
proxy.go
pwa.go
queue.go
quota.go
quota_test.go
repository.go
repository_archive.go
repository_archive_test.go
repository_test.go
security.go	chore: unify signing key configuration across modules (#11194)	2026-04-21 19:39:33 +02:00
server.go	fix: terminate git (& other) subcommands gracefully on context timeout/cancellation (#13263)	2026-07-01 20:26:02 +02:00
server_test.go
service.go	feat: setting to add team members by invitations (#12845)	2026-06-15 01:46:25 +02:00
service_test.go
session.go
setting.go	chore(docs): clarify the bootstrap fatal error message displayed when no config is found (#13268)	2026-07-01 15:59:39 +02:00
setting_test.go
ssh.go
storage.go	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
storage_test.go
task.go
time.go
ui.go	feat(api,ui): add multiline comment on pullrequest (#12582)	2026-06-03 16:06:29 +02:00
webhook.go