gitforge/services/doctor
oliverpool b1b47e64d7 fix(doctor): ensure the doctor runs with the same settings.AppPath as Forgejo (#12901)
Attempt to address #11705 and #11028.

The docker container runs gitea by default: 1d12151086/docker/root/etc/s6/gitea/run

Whereas a user might run `forgejo doctor ...` (which is symlinked to gitea).

So the doctor expects a different value for the authorized_keys command.

This fix does the opposite of syncAppConfForGit: it fetches the `AppPath` from the database to ensure it is the same as forgejo:
1d12151086/routers/init.go (L76-L87)

### Testing

1. Make a symlink called `forgejo`, pointing to gitea `ln -s gitea forgejo`
2. Run `./gitea` and add a ssh key to a user
3. Stop `./gitea`
4. Run `./forgejo doctor check --run authorized-keys`

Without this fix, the last command should fail.
With the fix, the last command should succeed and print:
```
- [I] AppPath changed from '/home/forgejo/forgejo' to '/home/forgejo/gitea'
```

- I ran...
  - [x] `make pr-go` before pushing

### Documentation

- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
- [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.

*The decision if the pull request will be shown in the release notes is up to the mergers / release team.*

The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12901
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
2026-06-06 03:23:06 +02:00
..
actions.go
authorizedkeys.go fix(doctor): ensure the doctor runs with the same settings.AppPath as Forgejo (#12901) 2026-06-06 03:23:06 +02:00
breaking.go
checkOldArchives.go
dbconsistency.go chore: rename 'migrations' to 'gitea_migrations' 2025-10-14 14:40:49 -06:00
dbversion.go chore: upgrade to https://code.forgejo.org/xorm/xorm v1.4.0 (#12639) 2026-05-20 20:20:08 +02:00
doctor.go
fix8312.go
fix16961.go
fix16961_test.go
heads.go
lfs.go feat: serve downsized versions of avatars (#11242) 2026-05-16 12:04:05 +02:00
misc.go feat: replace repo based server-side hooks with centralised hooks (#10397) 2026-04-27 22:34:46 +02:00
packages_nuget.go
paths.go
push_mirror_consistency.go chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
repository.go fix: cleanup data before migration retry (#12370) 2026-05-05 12:41:42 +02:00
storage.go feat: serve downsized versions of avatars (#11242) 2026-05-16 12:04:05 +02:00
usertype.go