mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-07-18 23:47:50 +00:00
d05002fbfb
Followup to https://codeberg.org/forgejo/forgejo/pulls/9598. A bug surfaced. When typing text in, JS was updating button's `textContent`, which also affected the icon included in the button. To avoid complex rebuilding of the button element in JS I just placed the text it it's own span, `textContent` of which is now updated by JS instead of the whole button. Preview Normal state from template: https://codeberg.org/attachments/f504bcc3-c1bc-4b10-96ae-e8b666c4a828 https://codeberg.org/attachments/5e72109c-04c7-49b0-ba05-e8f17c949fcb After editing text, without the fix: https://codeberg.org/attachments/2c61b02f-b36a-4b80-8816-98bed3fc48e0 https://codeberg.org/attachments/923d4419-97ee-48c6-b60d-9719e36ae6ff With the fix: https://codeberg.org/attachments/458c1f6a-549e-4ef7-8822-8529351b7bc4 https://codeberg.org/attachments/839032f7-2f4a-488a-a8a5-d3fbfc45504b Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9959 Reviewed-by: Otto <otto@codeberg.org> |
||
|---|---|---|
| .. | ||
| components | ||
| features | ||
| markup | ||
| modules | ||
| render | ||
| standalone | ||
| utils | ||
| vendor | ||
| webcomponents | ||
| bootstrap.js | ||
| bootstrap.test.js | ||
| emoji.test.js | ||
| htmx.js | ||
| index.js | ||
| jquery.js | ||
| svg.js | ||
| svg.test.js | ||
| types.d.ts | ||
| utils.js | ||
| utils.test.js | ||
| vitest.setup.js | ||