gitforge/modules/templates
0ko b4c8a8dbb2 fix(ui): bring back non-empty check to ThemeName (#13175)
Followup to https://codeberg.org/forgejo/forgejo/pulls/13110, which introduced a regression.

`SignedUser` is not guaranteed to be nil for guest users. Instead, we're setting it to non-nil user with ID 0 in some places, like:
e7c45cd9c8/services/context/org.go (L168-L171)

In https://codeberg.org/forgejo/forgejo/pulls/13110, I removed the check assuming it was for handling cases where real user's theme is set to "", after making sure it can't happen. This broke display of org pages to guest users and no tests caught it.

This unreliability of `SignedUser` doesn't seem ideal but I've assessed my chances of improving this without introducing more regressions as low, so I just brought the check back.

Noticed on v16.next. Demonstration:
![](https://codeberg.org/attachments/14ece26b-f02a-4e73-90a3-057d1a9962af)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13175
Reviewed-by: Robert Wolff <mahlzahn@posteo.de>
2026-06-23 11:53:17 +02:00
..
eval chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
scopedtmpl chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
vars
base.go
context.go chore: move template context (#8663) 2025-07-25 11:55:15 +02:00
context_test.go chore: move template context (#8663) 2025-07-25 11:55:15 +02:00
dynamic.go
helper.go fix(ui): bring back non-empty check to ThemeName (#13175) 2026-06-23 11:53:17 +02:00
helper_test.go
htmlrenderer.go chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
htmlrenderer_test.go
mailer.go
main_test.go chore: move all test blank imports in a single package (#10662) 2026-01-02 05:32:32 +01:00
static.go
templates_bindata.go
util_avatar.go
util_date.go feat(ui): commit view redesign for pull request page (#7948) 2026-06-02 20:12:32 +02:00
util_date_test.go
util_dict.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
util_json.go
util_misc.go fix: store pull mirror creds encrypted with keying (#11909) 2026-04-04 13:53:22 +02:00
util_misc_test.go
util_render.go chore: add modernizer linter (#11936) 2026-04-02 03:29:37 +02:00
util_render_test.go feat(ui): commit view redesign for pull request page (#7948) 2026-06-02 20:12:32 +02:00
util_slice.go
util_string.go feat(issue-search): support query syntax (#9109) 2025-11-19 16:05:42 +01:00
util_string_test.go
util_test.go